LGTM
https://codereview.chromium.org/16542003/diff/6001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/16542003/diff/6001/src/compiler.cc#newcode146
src/compiler.cc:146: for (int j = 0; j < group_maps->length(); j++) {
This has O(n^2) complexity. It is probably OK. I am not sure if there
are cases with large number of maps in code.
https://codereview.chromium.org/16542003/diff/6001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/16542003/diff/6001/src/objects.cc#newcode11098
src/objects.cc:11098:
info->dependent_maps(group)->Add(Handle<Map>(this), info->zone());
Note that this can add duplicate maps into dependent_maps(group). If
performance becomes an issue, we might want to revisit this.
https://codereview.chromium.org/16542003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
