https://codereview.chromium.org/16562005/diff/9001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/16562005/diff/9001/test/cctest/test-api.cc#newcode2668
test/cctest/test-api.cc:2668: int byteOffset,
On 2013/06/07 12:21:08, Sven Panne wrote:
Using size_t instead of int for offset/length is cleaner and even gets
rid of
the casts below.
No it does not get rid of casts - compiler gets confused about what
overload for CheckEqualsHelper to use:
./test/cctest/test-api.cc:2672:3: error: call to 'CheckEqualsHelper' is
ambiguous
CHECK_EQ(length, ta->Length());
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I'll land as is, but maybe we should consider size_t overload for
CheckEqualsHelper or smth.
Yell if you don't like it.
https://codereview.chromium.org/16562005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
