Reviewers: Jakob,

Message:
Committed patchset #1 manually as r15016 (presubmit successful).

Description:
Try to deflake cctest/test-cpu-profiler/NativeAccessorNameInProfile1 on Windows

Make native accessors sleep for 1ms before measuring elapsed time. This is to check the theory that we cannot pause profiled thread on Win64 for some reason
and miss many samples.

BUG=None
[email protected]

Committed: https://code.google.com/p/v8/source/detail?r=15016

Please review this at https://codereview.chromium.org/16656003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M test/cctest/test-cpu-profiler.cc


Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc index a4a525d8fe98f70618fd64bf14834cbf1f96d99c..188fbd948066ade0def73c4c894d1ba515aa5477 100644
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -681,6 +681,7 @@ class FooAccessorsData {
     double start = i::OS::TimeCurrentMillis();
     double duration = 0;
     while (duration < min_duration_ms_) {
+      i::OS::Sleep(1);
       duration = i::OS::TimeCurrentMillis() - start;
       ++*iterations;
     }


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to