LGTM with a nit.
https://codereview.chromium.org/16642003/diff/2001/src/arguments.h
File src/arguments.h (right):
https://codereview.chromium.org/16642003/diff/2001/src/arguments.h#newcode256
src/arguments.h:256: values[T::kReturnValueDefaultValueIndex] =
How do we make sure that the hole never escapes to JavaScript land? I
can't immediately see why this is guaranteed, so at least a comment
might be appropriate.
https://codereview.chromium.org/16642003/diff/2001/src/arguments.h#newcode318
src/arguments.h:318: values[T::kReturnValueDefaultValueIndex] =
Same here.
https://codereview.chromium.org/16642003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
