LGTM with nits
https://codereview.chromium.org/16732002/diff/2001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/16732002/diff/2001/src/arm/full-codegen-arm.cc#newcode4777
src/arm/full-codegen-arm.cc:4777: nil);
Nit: fits on previous line now (similarly in other backends)
https://codereview.chromium.org/16732002/diff/2001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/16732002/diff/2001/src/code-stubs.h#newcode1222
src/code-stubs.h:1222: InitializationState init_state)
Nit: fits on one line now
https://codereview.chromium.org/16732002/diff/2001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/16732002/diff/2001/src/hydrogen.cc#newcode9926
src/hydrogen.cc:9926: value, (nil== kNullValue) ?
graph()->GetConstantNull()
Nit: space before ==
https://codereview.chromium.org/16732002/diff/2001/src/mips/full-codegen-mips.cc
File src/mips/full-codegen-mips.cc (left):
https://codereview.chromium.org/16732002/diff/2001/src/mips/full-codegen-mips.cc#oldcode4808
src/mips/full-codegen-mips.cc:4808: EqualityKind kind = expr->op() ==
Token::EQ_STRICT
Please don't change MIPS code
https://codereview.chromium.org/16732002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
