Revision: 15037
Author:   [email protected]
Date:     Mon Jun 10 07:22:41 2013
Log:      Fix store buffer ensure space heuristics.

This change results in less scan on scavenge memory chunks.

BUG=
[email protected]

Review URL: https://codereview.chromium.org/15896037
http://code.google.com/p/v8/source/detail?r=15037

Modified:
 /branches/bleeding_edge/src/store-buffer.cc

=======================================
--- /branches/bleeding_edge/src/store-buffer.cc Wed Apr 24 04:20:16 2013
+++ /branches/bleeding_edge/src/store-buffer.cc Mon Jun 10 07:22:41 2013
@@ -188,10 +188,10 @@
     { 3, ((Page::kPageSize / kPointerSize) / 3) / 256 },
     { 1, 0}
   };
-  for (int i = kSampleFinenesses - 1; i >= 0; i--) {
+  for (int i = 0; i < kSampleFinenesses; i++) {
     ExemptPopularPages(samples[i].prime_sample_step, samples[i].threshold);
// As a last resort we mark all pages as being exempt from the store buffer.
-    ASSERT(i != 0 || old_top_ == old_start_);
+    ASSERT(i != (kSampleFinenesses - 1) || old_top_ == old_start_);
     if (old_limit_ - old_top_ > old_top_ - old_start_) return;
   }
   UNREACHABLE();

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to