[v8-dev] Re: Increase sanity of integer division handling on ARM (issue 16082008)

Mon, 10 Jun 2013 11:12:07 -0700 


https://codereview.chromium.org/16082008/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/16082008/diff/1/src/arm/code-stubs-arm.cc#newcode2219
src/arm/code-stubs-arm.cc:2219: __ add(scratch2, scratch1,
Operand(0x40000000), SetCC);
a possible improvement:

  __ SmiTag(scratch1, SetCC);  // adds s1, s1, s1
  __ b(vs, &return_heap_number);
  ASSERT(kSmiTag == 0);
  __ b(ne, &not_zero);
  ...
  __ bind(&not_zero);
  __ mov(r0, Operand(scratch1));
  ...

https://codereview.chromium.org/16082008/diff/1/src/arm/code-stubs-arm.cc#newcode2229
src/arm/code-stubs-arm.cc:2229: __ b(ne, result_type_ <=
BinaryOpIC::INT32 ? &transition
We now know result_type <= INT32

https://codereview.chromium.org/16082008/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to