LGTM with a nit.
https://codereview.chromium.org/16621004/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/16621004/diff/1/test/cctest/test-api.cc#newcode1041
test/cctest/test-api.cc:1041: kNullReturnValue = 1,
Is there a deep reason for the "= 1" part? If I see things correctly,
the actual starting value doesn't matter. Perhaps add a comment...
https://codereview.chromium.org/16621004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
