LGTM in the sense that it will probably work. Nevertheless, I don't like the
current chaos regarding -0. We mix up 2 totally unrelated things IMHO: If
the
result of an operation can be -0 (by the definition of the operation in the
spec, can_be_minus_zero_) and if we actually care about the difference
between
-0 and 0 (kBailoutOnMinusZero). We should clean this up in some different
CL,
the current state of affairs makes me cry... :-P
https://codereview.chromium.org/16741002/diff/11001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/16741002/diff/11001/src/hydrogen-instructions.h#newcode1003
src/hydrogen-instructions.h:1003: bool
HasAtLeastOneUseWithFlagAndNoneWithout(Flag f);
This helper predicate is totally confusing and hard to make sense of.
Remove it and simply use a combination of CheckUsesForFlag and either
uses()->Done() (more efficient) or UseCount() at its single call site.
https://codereview.chromium.org/16741002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
