On 2013/06/11 11:23:06, Yury Semikhatsky wrote:
https://codereview.chromium.org/16035027/diff/7001/src/handles.cc File src/handles.cc (right):
https://codereview.chromium.org/16035027/diff/7001/src/handles.cc#newcode369 src/handles.cc:369: if (!isolate->IsInitialized()) { Can we move this check to Logger::LogExistingFunction or toGetScriptNameOrSourceURL? Logger::LogExistingFunction should be the only place where isolate is not initialized and we are trying to create a script wrapper.
BTW, how can it happen that we have Script but no initialized Isolate?
https://codereview.chromium.org/16035027/diff/7001/src/handles.cc#newcode614 src/handles.cc:614: if (property->IsJSFunction()) { How can it happen? We should be checking for is_bootstrapping or something instead I think.
The only thing we have to check is the isolate->IsInitialized() We can do that in GetScriptNameOrSourceURL. https://codereview.chromium.org/16035027/diff/7001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/16035027/diff/7001/test/cctest/test-cpu-profiler.cc#newcode563
test/cctest/test-cpu-profiler.cc:563:
CHECK_EQ(v8::String::New("cpu_profiler_test_source.js"),
I'd rather have it tested in a separate test.
extracted https://codereview.chromium.org/16035027/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
