LGTM with one real comment about the SpaceAvailable method.
https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.cc
File src/store-buffer.cc (left):
https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.cc#oldcode690
src/store-buffer.cc:690: CheckForFullBuffer();
As discussed offline: I am a little bit worried that removing this call
will cause increase in number of store-buffer compactions. But if the
impact is not measurable I am fine with landing it.
https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.h
File src/store-buffer.h (right):
https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.h#newcode114
src/store-buffer.h:114: bool SpaceAvailable(intptr_t space_needed);
This helper function should definitely be private, please move it down
(e.g. to where 'Uniq' is declared).
https://codereview.chromium.org/16690006/diff/6001/src/store-buffer.h#newcode115
src/store-buffer.h:115: void EnsureSpace(intptr_t space_needed);
As discussed offline: It would be great to have only one of the two
"Compact" and "EnsureSpace" entry points. There is only one call-site of
EnsureSpace left after this patch, I like that.
https://codereview.chromium.org/16690006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
