Addressed comments. Landing.
https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc#newcode1135
src/mark-compact.cc:1135: PrintF("[code-flushing resurrects: %s]\n",
*name);
On 2013/06/11 14:07:17, Hannes Payer wrote:
why don't you say "code-flushing evicts: ..."?
As discussed offline: Using 'evicts' here sound a lot like the
code-flusher actually did flush the code, which is not the case. We
decided to use 'abandons' instead.
https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc#newcode1171
src/mark-compact.cc:1171: PrintF("[code-flushing resurrects: %s]\n",
*name);
On 2013/06/11 14:07:17, Hannes Payer wrote:
why don't you say "code-flushing evicts: ..."?
See above.
https://codereview.chromium.org/16773002/diff/1/src/mark-compact.cc#newcode1197
src/mark-compact.cc:1197: void
CodeFlusher::EvictOptimizedCodeMap(SharedFunctionInfo* code_map_holder)
{
On 2013/06/11 14:07:17, Hannes Payer wrote:
Do you want to add tracing support to this function as well?
Done.
https://codereview.chromium.org/16773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
