I have updated the tests and addressed CR comments.
I don't think I have a password for v8.googlecode.com
Can one of the reviewers commit the change?
https://codereview.chromium.org/9156001/diff/22003/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/9156001/diff/22003/src/hydrogen-instructions.cc#newcode2387
src/hydrogen-instructions.cc:2387: */
On 2013/06/11 10:22:37, fschneider wrote:
Remove commented code.
Done.
https://codereview.chromium.org/9156001/diff/22003/src/hydrogen-instructions.cc#newcode2391
src/hydrogen-instructions.cc:2391: if (left()->range() != NULL)
On 2013/06/11 12:47:46, Toon Verwaest wrote:
if (left()->HasRange()) {
...
}
Done.
https://codereview.chromium.org/9156001/diff/22003/test/cctest/test-bitrange.cc
File test/cctest/test-bitrange.cc (right):
https://codereview.chromium.org/9156001/diff/22003/test/cctest/test-bitrange.cc#newcode1
test/cctest/test-bitrange.cc:1: // Copyright 2010 the V8 project
authors. All rights reserved.
On 2013/06/11 10:22:37, fschneider wrote:
2013
Done.
https://codereview.chromium.org/9156001/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
