Lookgin good already, just one comment.
https://codereview.chromium.org/16801006/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/16801006/diff/1/src/ia32/full-codegen-ia32.cc#newcode1955
src/ia32/full-codegen-ia32.cc:1955: if (expr->yield_kind() ==
Yield::SUSPEND) {
This can be modeled by flipping the two cases above, moving the
additional steps for Yield::SUSPEND up and letting it fall-through to
Yield::INITIAL. I think that would be easier to read. Same applies to
other architectures.
https://codereview.chromium.org/16801006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
