Revision: 15086
Author: [email protected]
Date: Wed Jun 12 07:05:56 2013
Log: Deprecate obsolete JSFunction::unchecked_shared accessor.
[email protected]
BUG=v8:1490
Review URL: https://codereview.chromium.org/16813005
http://code.google.com/p/v8/source/detail?r=15086
Modified:
/branches/bleeding_edge/src/mark-compact.cc
/branches/bleeding_edge/src/objects-inl.h
/branches/bleeding_edge/src/objects-visiting-inl.h
/branches/bleeding_edge/src/objects.h
=======================================
--- /branches/bleeding_edge/src/mark-compact.cc Wed Jun 12 05:39:15 2013
+++ /branches/bleeding_edge/src/mark-compact.cc Wed Jun 12 07:05:56 2013
@@ -2418,7 +2418,7 @@
// This map is used for inobject slack tracking and has been detached
// from SharedFunctionInfo during the mark phase.
// Since it survived the GC, reattach it now.
-
map->unchecked_constructor()->unchecked_shared()->AttachInitialMap(map);
+ map->unchecked_constructor()->shared()->AttachInitialMap(map);
}
ClearNonLivePrototypeTransitions(map);
=======================================
--- /branches/bleeding_edge/src/objects-inl.h Wed Jun 12 02:43:22 2013
+++ /branches/bleeding_edge/src/objects-inl.h Wed Jun 12 07:05:56 2013
@@ -4967,12 +4967,6 @@
Object* JSFunction::unchecked_context() {
return READ_FIELD(this, kContextOffset);
}
-
-
-SharedFunctionInfo* JSFunction::unchecked_shared() {
- return reinterpret_cast<SharedFunctionInfo*>(
- READ_FIELD(this, kSharedFunctionInfoOffset));
-}
void JSFunction::set_context(Object* value) {
=======================================
--- /branches/bleeding_edge/src/objects-visiting-inl.h Fri Jun 7 03:52:11
2013
+++ /branches/bleeding_edge/src/objects-visiting-inl.h Wed Jun 12 07:05:56
2013
@@ -414,7 +414,7 @@
// Visit shared function info immediately to avoid double checking
// of its flushability later. This is just an optimization because
// the shared function info would eventually be visited.
- SharedFunctionInfo* shared = function->unchecked_shared();
+ SharedFunctionInfo* shared = function->shared();
if (StaticVisitor::MarkObjectWithoutPush(heap, shared)) {
StaticVisitor::MarkObject(heap, shared->map());
VisitSharedFunctionInfoWeakCode(heap, shared);
@@ -595,7 +595,7 @@
template<typename StaticVisitor>
bool StaticMarkingVisitor<StaticVisitor>::IsFlushable(
Heap* heap, JSFunction* function) {
- SharedFunctionInfo* shared_info = function->unchecked_shared();
+ SharedFunctionInfo* shared_info = function->shared();
// Code is either on stack, in compilation cache or referenced
// by optimized version of function.
=======================================
--- /branches/bleeding_edge/src/objects.h Wed Jun 12 05:39:15 2013
+++ /branches/bleeding_edge/src/objects.h Wed Jun 12 07:05:56 2013
@@ -6581,8 +6581,6 @@
// can be shared by instances.
DECL_ACCESSORS(shared, SharedFunctionInfo)
- inline SharedFunctionInfo* unchecked_shared();
-
// [context]: The context for this function.
inline Context* context();
inline Object* unchecked_context();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.