LGTM with a comment.
https://chromiumcodereview.appspot.com/16957005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/16957005/diff/1/src/hydrogen.cc#newcode9924
src/hydrogen.cc:9924: if (left_rep.IsInteger32()) left_rep =
Representation::Smi();
I think it would be a bit cleaner to formulate the condition in terms of
the Type info that was originally translated into left_rep. After
rebasing to bleeding_edge, that will look like:
if (left_type->Is(Type::Integer31())) left_rep = Representation::Smi();
https://chromiumcodereview.appspot.com/16957005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
