https://codereview.chromium.org/17058002/diff/1/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/17058002/diff/1/src/spaces.cc#newcode2147
src/spaces.cc:2147: return NULL;
On 2013/06/14 09:44:53, Michael Starzinger wrote:
This is not necessarily correct. The check only verifies that the
top-most
free-list entry is big enough. If the top-most free-list entry happens
to be on
an evacuation candidate we cannot allocate it and will take a
subsequent entry
which in turn might be smaller.
As discussed offline: Let's either duplicate the above functionality
and do the
size check after evacuation candidates have been skipped, or call
PichNodeFromList and return the entry back if size doesn't fit.
Done. I ended up not duplicating the code, since I do not think we will
go to the linear size allocation approach anytime soon. Given the block
back using the existing API is cleaner.
https://codereview.chromium.org/17058002/diff/1/src/spaces.cc#newcode2245
src/spaces.cc:2245: if ((owner_->ConstantAllocationSize() &&
size_in_bytes <= kSmallListMax) ||
On 2013/06/14 09:44:53, Michael Starzinger wrote:
This change supersedes the previous optimization to also look at the
smallest
bucket for constant-size spaces. Let's take out this optimization
(plus the
ConstantAllocationSize predicate) again.
Done.
https://codereview.chromium.org/17058002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
