On 2013/06/15 06:31:55, Yury Semikhatsky wrote:
On 2013/06/14 20:21:30, Yury Semikhatsky wrote:
> On 2013/06/14 17:35:45, dcarney wrote:
> > this seems reasonable, but so would a simple profile scope or
something of
> that
> > nature. I guess it depends how many such tests need to exist and how
spread
> out
> > they are. Ultimately Sven and Michael need to decide
>
> I think there are going to be enough such tests to justify adding the
macro,
see
> https://chromiumcodereview.appspot.com/17059005/
It just occured to me that and alternative solution would be to
define "void
RunWithProfiler(void (*original_test)())" in test-api.cc and then for
THREADED_TEST(FunctionTemplate) {..}
add
TEST(FunctionTemplateWithProfiler) {
RunWithProfiler(TestFunctionTemplate);
}
To save some typing this still can be declared using a
THREADED_PROFILED_TEST
macro defined in test-api.cc
Does it sound like a better approach?
Moved THREADED_PROFILED_TEST macro definition into test-api.cc, now the
change
looks better. Please take a look.
https://codereview.chromium.org/17072002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
