Reviewers: Sven Panne,
Message:
On 2013/06/16 13:33:55, Sven Panne wrote:
https://codereview.chromium.org/17099008/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/17099008/diff/1/src/hydrogen-instructions.h#newcode3236
src/hydrogen-instructions.h:3236: virtual bool IsDeletable() const {
return
false; }
DBC: Just remove the whole line, 'false' is the (safe) default, anyway...
Good point; but Michael has a better fix anyway (preserving deletability of
HArgumentsObject). Closing this issue.
Description:
Dead code elimination must not delete HArgumentsObject
BUG=chromium:249894
Closing in favor of https://codereview.chromium.org/16938009/.
Please review this at https://codereview.chromium.org/17099008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index
7554fd85bad5a136e387698eb704159008be7bdd..ac83b3ef6a929a0c759b13929cb4518d96ff5aa7
100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -3233,7 +3233,7 @@ class HArgumentsObject: public
HTemplateInstruction<0> {
}
private:
- virtual bool IsDeletable() const { return true; }
+ virtual bool IsDeletable() const { return false; }
ZoneList<HValue*> values_;
};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
