Reviewers: Jakob,
Description:
Make sure GCMole pukes when Clang invocation fails.
[email protected]
Please review this at https://codereview.chromium.org/16878003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M tools/gcmole/gcmole.lua
Index: tools/gcmole/gcmole.lua
diff --git a/tools/gcmole/gcmole.lua b/tools/gcmole/gcmole.lua
index
b259ee014319a1b26a74efcc57c05786c78c7cab..66aff942a49927a20fbc0a24e58f3d1e6de4b481
100644
--- a/tools/gcmole/gcmole.lua
+++ b/tools/gcmole/gcmole.lua
@@ -117,7 +117,8 @@ function InvokeClangPluginForEachFile(filenames, cfg,
func)
if FLAGS.verbose then print('popen ', action) end
local pipe = io.popen(action)
func(filename, pipe:lines())
- pipe:close()
+ local success = pipe:close()
+ if not success then error("Failed to run: " .. action) end
end
end
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
