LGTM with comments that apply to all platforms.
https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-codegen-ia32.h
File src/ia32/lithium-codegen-ia32.h (right):
https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-codegen-ia32.h#newcode320
src/ia32/lithium-codegen-ia32.h:320: void EmitBranch(InstrType instr,
Condition cc);
Instead of templatizing this, can you change the signature to
"EmitBranch(LControlInstruction* instr, Condition cc)", or does that
make the compiler unhappy?
https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-ia32.h
File src/ia32/lithium-ia32.h (right):
https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-ia32.h#newcode486
src/ia32/lithium-ia32.h:486: false_label_ = true_label_ = NULL;
nit: Use initializers:
LControlInstruction() : false_label_(NULL), true_label_(NULL) {}
https://codereview.chromium.org/17276002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
