On 2013/06/18 09:47:54, machenbach wrote:
>
https://chromiumcodereview.appspot.com/17260002/diff/15001/test/webkit/testcfg.py#newcode52
> test/webkit/testcfg.py:52: if dirname == exclude:
> I guess this works, but it doesn't fit with the exclusion scheme used
right
> above. How about:
>
> exclude = 'resources'
> if exclude in dirs:
> dirs.remove(exclude)
>
> That way we won't even visit the 'resources' directory.
> Or you could modify/extend the existing filter:
>
> for excluded in [x for x in dirs if x.startswith('.') or x
== 'resources']:
> dirs.remove(excluded)
With both suggested ways, we would ignore _every_ subdir
called 'resources'.
Yes, that was actually my intention.
If
the test suite grows, there could be a subdir for 'resource' tests
somewhere
called special_tests/resources, which we would also ignore.
I don't think that's a problem. It should be OK to give special meaning to
the
directory name 'resources', at least within the webkit test suite.
https://chromiumcodereview.appspot.com/17260002/diff/15001/test/webkit/testcfg.py#newcode122
> test/webkit/testcfg.py:122: if line.startswith("#") or not line.strip():
> continue
> Don't you need to have this line in ActIterator too to filter out the
copyright
> headers?
No - the test cases don't print out the license header.
Right. I got that backwards.
https://codereview.chromium.org/17260002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
