Revision: 15194
Author: [email protected]
Date: Tue Jun 18 06:32:06 2013
Log: Remove obsolete elements kind check for array literals.
[email protected]
Review URL: https://codereview.chromium.org/17378005
http://code.google.com/p/v8/source/detail?r=15194
Modified:
/branches/bleeding_edge/src/hydrogen.cc
/branches/bleeding_edge/test/mjsunit/tools/tickprocessor.js
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Fri Jun 14 10:02:39 2013
+++ /branches/bleeding_edge/src/hydrogen.cc Tue Jun 18 06:32:06 2013
@@ -6049,26 +6049,6 @@
// pass an empty fixed array to the runtime function instead.
Handle<FixedArray> constants =
isolate()->factory()->empty_fixed_array();
int literal_index = expr->literal_index();
-
- // TODO(mstarzinger): The following check and deopt is actually
obsolete
- // but test cases for the tick processor fails because profile differs.
-
- // Deopt if the array literal boilerplate ElementsKind is of a type
- // different than the expected one. The check isn't necessary if the
- // boilerplate has already been converted to
TERMINAL_FAST_ELEMENTS_KIND.
- if (CanTransitionToMoreGeneralFastElementsKind(
- boilerplate_elements_kind, true)) {
- IfBuilder builder(this);
- HValue* boilerplate = AddInstruction(new(zone())
- HConstant(original_boilerplate_object));
- HValue* elements_kind = AddInstruction(new(zone())
- HElementsKind(boilerplate));
- HValue* expected_kind = AddInstruction(new(zone())
- HConstant(boilerplate_elements_kind));
- builder.IfCompare(elements_kind, expected_kind, Token::EQ);
- builder.Then();
- builder.ElseDeopt();
- }
AddInstruction(new(zone()) HPushArgument(AddInstruction(
new(zone()) HConstant(literals))));
=======================================
--- /branches/bleeding_edge/test/mjsunit/tools/tickprocessor.js Tue Jan 29
06:41:02 2013
+++ /branches/bleeding_edge/test/mjsunit/tools/tickprocessor.js Tue Jun 18
06:32:06 2013
@@ -25,6 +25,10 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+// This test case is not compatible with optimization stress because the
+// generated profile will look vastly different when more is optimized.
+// Flags: --nostress-opt --noalways-opt
+
// Load implementations from <project root>/tools.
// Files: tools/splaytree.js tools/codemap.js tools/csvparser.js
// Files: tools/consarray.js tools/profile.js tools/profile_view.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
