first round of comments.
https://codereview.chromium.org/17082003/diff/3001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/17082003/diff/3001/src/hydrogen-instructions.cc#newcode1290
src/hydrogen-instructions.cc:1290: if
(expected_input_types_.ContainsAnyOf(number_types)) {
Are you sure you want to make smi+undefined double rather than tagged?
Seems like tagged would be faster; given that smis are valid tagged
objects; and you need to do a smi-check anyway.
I'd rather make undefined a special case of Contains(HEAP_NUMBER).
https://codereview.chromium.org/17082003/diff/3001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/17082003/diff/3001/src/ia32/lithium-codegen-ia32.cc#newcode2139
src/ia32/lithium-codegen-ia32.cc:2139: } else if (type.IsHeapNumber()) {
ASSERT(!info()->IsStub());
XMM is not available for stubs.
https://codereview.chromium.org/17082003/diff/3001/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):
https://codereview.chromium.org/17082003/diff/3001/src/x64/lithium-x64.cc#newcode1022
src/x64/lithium-x64.cc:1022: expected != ToBooleanStub::all_types()) {
Can you add a comment what expected == all_types means?
Also, can we make ia32/x64 and ARM agree on &&,! vs ||?
https://codereview.chromium.org/17082003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
