LGTM with nits.
https://codereview.chromium.org/16950013/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/16950013/diff/1/src/heap.cc#newcode1745
src/heap.cc:1745:
nit: Add a second empty newline.
https://codereview.chromium.org/16950013/diff/1/src/heap.cc#newcode1748
src/heap.cc:1748: for (Object* o = array_buffers_list();
nit: Should fit into one line.
https://codereview.chromium.org/16950013/diff/1/src/heap.cc#newcode1753
src/heap.cc:1753: }
Let's play it safe and reset array_buffers_list to undefined here.
https://codereview.chromium.org/16950013/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/16950013/diff/1/src/heap.h#newcode2195
src/heap.h:2195: void TearDownArrayBuffers();
nit: Let's add a short one-liner comments clarifying that this is only
used during heap tear-down ...
// Destroys all memory allocated for array buffers when heap is torn
down.
https://codereview.chromium.org/16950013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
