Revision: 15213
Author: [email protected]
Date: Wed Jun 19 10:20:25 2013
Log: MIPS: Fix test-cpu-profiler/SampleWhenFrameIsNotSetup flakiness
on MIPS simulator.
BUG=v8:2628
TEST=cctest/test-cpu-profiler/SampleWhenFrameIsNotSetup
[email protected], [email protected]
Review URL: https://codereview.chromium.org/17265004
Patch from Dusan Milosavljevic <[email protected]>.
http://code.google.com/p/v8/source/detail?r=15213
Modified:
/branches/bleeding_edge/src/mips/simulator-mips.h
/branches/bleeding_edge/test/cctest/cctest.status
=======================================
--- /branches/bleeding_edge/src/mips/simulator-mips.h Thu Apr 11 19:01:52
2013
+++ /branches/bleeding_edge/src/mips/simulator-mips.h Wed Jun 19 10:20:25
2013
@@ -316,8 +316,6 @@
if (instr->InstructionBits() == nopInstr) {
// Short-cut generic nop instructions. They are always valid and they
// never change the simulator state.
- set_register(pc, reinterpret_cast<int32_t>(instr) +
- Instruction::kInstrSize);
return;
}
=======================================
--- /branches/bleeding_edge/test/cctest/cctest.status Tue Jun 11 07:31:46
2013
+++ /branches/bleeding_edge/test/cctest/cctest.status Wed Jun 19 10:20:25
2013
@@ -75,9 +75,6 @@
##############################################################################
[ $arch == mipsel ]
-# BUG(2628): The test sometimes fails on MIPS simulator.
-test-cpu-profiler/SampleWhenFrameIsNotSetup: PASS || FAIL
-
# BUG(2657): Test sometimes times out on MIPS simulator.
test-thread-termination/TerminateMultipleV8ThreadsDefaultIsolate: PASS ||
TIMEOUT
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
