Reviewers: Michael Starzinger,
Message:
It makes sense to use +kCallerSPOffset instead of -kMarkerOffset to compute
the
args pointer. kCallerSPOffset is what we have lost from (output_frame_size -
output_frame_offset).
This change is needed for X32 as +kCallerSPOffset is not equal to
-kMarkerOffset.
Description:
Use +kCallerSPOffset instead of -kMarkerOffset to compute the args pointer.
Please review this at https://codereview.chromium.org/17451014/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/deoptimizer.cc
Index: src/deoptimizer.cc
===================================================================
--- src/deoptimizer.cc (revision 15216)
+++ src/deoptimizer.cc (working copy)
@@ -1511,8 +1511,8 @@
}
output_frame_offset -= kPointerSize;
- value = frame_ptr - (output_frame_size - output_frame_offset) -
- StandardFrameConstants::kMarkerOffset + kPointerSize;
+ value = frame_ptr - (output_frame_size - output_frame_offset) +
+ StandardFrameConstants::kCallerSPOffset + kPointerSize;
output_frame->SetFrameSlot(output_frame_offset, value);
if (trace_) {
PrintF(" 0x%08" V8PRIxPTR ": [top + %d] <- 0x%08"
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
