https://codereview.chromium.org/15990004/diff/3001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/15990004/diff/3001/src/ia32/full-codegen-ia32.cc#newcode1967
src/ia32/full-codegen-ia32.cc:1967:
Immediate(Smi::FromInt(continuation.pos())));
It's too bad that we cannot reliably predict the binding offset of
"resume" here, otherwise the two jumps at the top would be obsolete.
Damn! <sarcasm>Maybe leave a comment in that regard to eternalize our
disappointment. :)</sarcasm>
https://codereview.chromium.org/15990004/diff/3001/src/ia32/full-codegen-ia32.cc#newcode2034
src/ia32/full-codegen-ia32.cc:2034: __ mov(eax, Operand(esp, (0 + 1) *
kPointerSize + handler_size)); // g
nit: The trailing '// g' comment is somewhat duplicated, let's drop it
for the '__mov' instruction.
https://codereview.chromium.org/15990004/diff/3001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/15990004/diff/3001/src/runtime.cc#newcode2614
src/runtime.cc:2614:
Can we leave a short comment here saying that JSGeneratorObject::context
and JSGeneratorObject::continuation are set by the caller in generated
code? Maybe even assert that both have been set correctly by the caller?
https://codereview.chromium.org/15990004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
