Michael, thanks for review.
https://codereview.chromium.org/17451014/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/17451014/diff/1/src/deoptimizer.cc#newcode1514
src/deoptimizer.cc:1514: value = frame_ptr - (output_frame_size -
output_frame_offset) +
On 2013/06/20 11:39:27, Michael Starzinger wrote:
nit: Can we re-order this calculation slightly? This would make it in
line with
the calculation of args.arguments and also easier to parse IMHO. I was
thinking
about the following order:
value = frame_ptr + StandardFrameConstants::kCallerSPOffset -
(output_frame_size - output_frame_offset) + kPointerSize;
Done.
https://codereview.chromium.org/17451014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
