Reviewers: danno, wingo, Paul Lind, palfia, kisg,
Description:
MIPS: Fix stack frame reconstruction for generators with formal arguments.
Port r15230 (e2bbe01)
Original commit message:
The formal parameter count was always being treated as an untagged
integer, but it is actually a Smi on ia32 and arm.
BUG=v8:2355
TEST=mjsunit/harmony/generators-iteration
Please review this at https://codereview.chromium.org/17261028/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/mips/full-codegen-mips.cc
Index: src/mips/full-codegen-mips.cc
diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc
index
df83019f15e4a9c349d425da19257592618f3d13..06226ca671d0372a2068bbe055fc7d80c3ace75e
100644
--- a/src/mips/full-codegen-mips.cc
+++ b/src/mips/full-codegen-mips.cc
@@ -2142,7 +2142,7 @@ void
FullCodeGenerator::EmitGeneratorResume(Expression *generator,
__ LoadRoot(a2, Heap::kTheHoleValueRootIndex);
Label push_argument_holes, push_frame;
__ bind(&push_argument_holes);
- __ Subu(a3, a3, Operand(1));
+ __ Subu(a3, a3, Operand(Smi::FromInt(1)));
__ Branch(&push_frame, lt, a3, Operand(zero_reg));
__ push(a2);
__ jmp(&push_argument_holes);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
