Revision: 15250
Author: [email protected]
Date: Thu Jun 20 08:29:22 2013
Log: MIPS: Fix stack frame reconstruction for generators with formal
arguments.
Port r15230 (e2bbe01)
Original commit message:
The formal parameter count was always being treated as an untagged
integer, but it is actually a Smi on ia32 and arm.
BUG=v8:2355
TEST=mjsunit/harmony/generators-iteration
Review URL: https://codereview.chromium.org/17261028
Patch from Balazs Kilvady <[email protected]>.
http://code.google.com/p/v8/source/detail?r=15250
Modified:
/branches/bleeding_edge/src/mips/full-codegen-mips.cc
=======================================
--- /branches/bleeding_edge/src/mips/full-codegen-mips.cc Fri Jun 14
04:35:00 2013
+++ /branches/bleeding_edge/src/mips/full-codegen-mips.cc Thu Jun 20
08:29:22 2013
@@ -2142,7 +2142,7 @@
__ LoadRoot(a2, Heap::kTheHoleValueRootIndex);
Label push_argument_holes, push_frame;
__ bind(&push_argument_holes);
- __ Subu(a3, a3, Operand(1));
+ __ Subu(a3, a3, Operand(Smi::FromInt(1)));
__ Branch(&push_frame, lt, a3, Operand(zero_reg));
__ push(a2);
__ jmp(&push_argument_holes);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.