More comments addressed.
https://codereview.chromium.org/17153011/diff/2001/test/mjsunit/harmony/dataview-accessors.js
File test/mjsunit/harmony/dataview-accessors.js (right):
https://codereview.chromium.org/17153011/diff/2001/test/mjsunit/harmony/dataview-accessors.js#newcode64
test/mjsunit/harmony/dataview-accessors.js:64: if (index < 0) index = 0;
On 2013/06/21 12:25:53, rossberg wrote:
On 2013/06/21 11:32:10, Dmitry Lomov (chromium) wrote:
> On 2013/06/21 08:44:01, rossberg wrote:
> > I don't understand. What use is runNegativeIndexTest below if you
correct it
> > anyway?
>
> Done.
This doesn't seem to be fixed.
No it is fixed - see the latest version of this file.
https://codereview.chromium.org/17153011/diff/15001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/17153011/diff/15001/src/runtime.cc#newcode1035
src/runtime.cc:1035: Handle<JSDataView>
data_view(JSDataView::cast(*holder));
On 2013/06/21 12:25:53, rossberg wrote:
You can just declare the type in the line above now. (here and below)
Done.
https://codereview.chromium.org/17153011/diff/15001/test/mjsunit/harmony/dataview-accessors.js
File test/mjsunit/harmony/dataview-accessors.js (right):
https://codereview.chromium.org/17153011/diff/15001/test/mjsunit/harmony/dataview-accessors.js#newcode96
test/mjsunit/harmony/dataview-accessors.js:96: {
On 2013/06/21 12:25:53, rossberg wrote:
Nit: style
Done.
https://codereview.chromium.org/17153011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
