Revision: 15267
Author: [email protected]
Date: Fri Jun 21 05:50:02 2013
Log: HBoundsCheck shouldn't ignore Tagged input representations
unconditionally
BUG=v8:2740
[email protected]
Review URL: https://codereview.chromium.org/16917003
http://code.google.com/p/v8/source/detail?r=15267
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.cc
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Fri Jun 21
04:10:06 2013
+++ /branches/bleeding_edge/src/hydrogen-instructions.cc Fri Jun 21
05:50:02 2013
@@ -1156,8 +1156,12 @@
HValue* actual_length = length()->ActualValue();
Representation index_rep = actual_index->representation();
Representation length_rep = actual_length->representation();
- if (index_rep.IsTagged()) index_rep = Representation::Smi();
- if (length_rep.IsTagged()) length_rep = Representation::Smi();
+ if (index_rep.IsTagged() && actual_index->type().IsSmi()) {
+ index_rep = Representation::Smi();
+ }
+ if (length_rep.IsTagged() && actual_length->type().IsSmi()) {
+ length_rep = Representation::Smi();
+ }
Representation r = index_rep.generalize(length_rep);
if (r.is_more_general_than(Representation::Integer32())) {
r = Representation::Integer32();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
