On 2013/06/24 11:03:33, Jakob wrote:
LGTM, just nits.
https://codereview.chromium.org/17592002/diff/1/tools/profviz/composer.js
File tools/profviz/composer.js (right):
https://codereview.chromium.org/17592002/diff/1/tools/profviz/composer.js#newcode49
tools/profviz/composer.js:49: var kTickHalfDuration = 0.5; //
Duration of
half a tick in seconds.
s/seconds/milliseconds/, I think
https://codereview.chromium.org/17592002/diff/1/tools/profviz/profviz.js
File tools/profviz/profviz.js (right):
https://codereview.chromium.org/17592002/diff/1/tools/profviz/profviz.js#newcode61
tools/profviz/profviz.js:61: console.log(event.data);
is this intentional?
Thanks for the review! I fixed the milliseconds thing. I left the
console.log
line there intentionally, but since it's not actually necessary, I removed
it.
Also added copyright headers to the html and css files.
https://codereview.chromium.org/17592002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
