Got some comments. LGTM once those are fixed.
https://codereview.chromium.org/16901014/diff/7001/src/log.cc
File src/log.cc (right):
https://codereview.chromium.org/16901014/diff/7001/src/log.cc#newcode865
src/log.cc:865: msg.Append("%s,%s,-3,",
We also got "-3" here to indicate external call. You changed this to -2
in plot-timer-events.js, so you need to apply the change here as well.
Maybe you can unify this part as well, and use an enum or a constant
instead of an inline "-3".
https://codereview.chromium.org/16901014/diff/7001/src/log.cc#newcode1514
src/log.cc:1514: case Code::REGEXP:
while we are at this, could we fix this here?
description = "Regular expression code";
tag = Logger::REG_EXP_TAG;
break;
https://codereview.chromium.org/16901014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
