Reviewers: danno,
Message:
Hello, Daniel.
I updated it. please review it.
Thanks.
Description:
In revision 15142, the V8_USE_UNSAFE_HANDLES define is removed.
So in the vtune support code ( in vtune-jit.cc file)v8::Handle<T* value>
consturctor cannot be invoked directly.
We use "->ToString()" to create the Handle<String> object to fix the
compilation error.
Please review this at https://codereview.chromium.org/17343005/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/third_party/vtune/vtune-jit.cc
Index: src/third_party/vtune/vtune-jit.cc
===================================================================
--- src/third_party/vtune/vtune-jit.cc (revision 15223)
+++ src/third_party/vtune/vtune-jit.cc (working copy)
@@ -192,8 +192,7 @@
if (*script != NULL) {
// Get the source file name and set it to
jmethod.source_file_name
if ((*script->GetScriptName())->IsString()) {
- Handle<String> script_name =
- Handle<String>(String::Cast(*script->GetScriptName()));
+ Handle<String> script_name =
script->GetScriptName()->ToString();
temp_file_name = new char[script_name->Utf8Length() + 1];
script_name->WriteUtf8(temp_file_name);
jmethod.source_file_name = temp_file_name;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
