Looks good so far, but a test case would be great. I'm not entirely sure
which
use case it would fix.
PS: sorry that the review took so long!
https://codereview.chromium.org/17636007/diff/3001/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/17636007/diff/3001/src/mirror-debugger.js#newcode1675
src/mirror-debugger.js:1675: this.details_.frameId(),
indentation is off by one.
https://codereview.chromium.org/17636007/diff/3001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/17636007/diff/3001/src/runtime.cc#newcode12380
src/runtime.cc:12380: // those copies are returned to the caller to
allow it track the changes and
do you mean "... to allow tracking the changes..." ?
https://codereview.chromium.org/17636007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
