Reviewers: Jakob,
Description:
Move C++ specific flags from C flags to C++ flags
This allows to compile non-C++ files in the v8 standalone build, e.g.
assembly files found in ICU.
[email protected]
BUG=2745
Please review this at https://codereview.chromium.org/17638009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
build/standalone.gypi
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index
dde05757df1049bc4593b4d0ffd676bcffe3c66e..f7ca0a66a9e7d651ca028040f1ab9f912084c8a3
100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -98,8 +98,8 @@
or OS=="netbsd"', {
'target_defaults': {
'cflags': [ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
- '-Wnon-virtual-dtor', '-pthread', '-fno-rtti',
- '-fno-exceptions', '-pedantic' ],
+ '-pthread', '-fno-exceptions', '-pedantic' ],
+ 'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti' ],
'ldflags': [ '-pthread', ],
'conditions': [
[ 'OS=="linux"', {
@@ -198,6 +198,7 @@
'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
'GCC_VERSION': 'com.apple.compilers.llvmgcc42',
'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof
+ 'GCC_WARN_NON_VIRTUAL_DESTRUCTOR': 'YES', # -Wnon-virtual-dtor
# MACOSX_DEPLOYMENT_TARGET maps to -mmacosx-version-min
'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)',
'PREBINDING': 'NO', # No -Wl,-prebind
@@ -211,7 +212,6 @@
'-Wendif-labels',
'-W',
'-Wno-unused-parameter',
- '-Wnon-virtual-dtor',
],
},
'target_conditions': [
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
