https://codereview.chromium.org/17657004/diff/1/src/hydrogen-gvn.h
File src/hydrogen-gvn.h (right):
https://codereview.chromium.org/17657004/diff/1/src/hydrogen-gvn.h#newcode82
src/hydrogen-gvn.h:82: HGlobalValueNumberingPhase(HGraph* graph, Zone*
zone);
Why do you need to pass the zone in? Shouldn't you be able to get it
from graph()->info()->phase_zone()?
https://codereview.chromium.org/17657004/diff/1/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/17657004/diff/1/src/hydrogen.h#newcode431
src/hydrogen.h:431: void Run() { Phase phase(this,
info()->phase_zone()); phase.Run(); }
Isn't this from another CL?
https://codereview.chromium.org/17657004/diff/1/src/hydrogen.h#newcode1966
src/hydrogen.h:1966: HPhase(const char* name, HGraph* graph, Zone*
zone);
again, why do you need to pass the zone in? Either you need the graph
zone (with graph->zone()) or the phase zone
(graph->info()->phase_zone()). Either way, you shouldn't have to pass it
in explicitly.
https://codereview.chromium.org/17657004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
