LGTM with nits.
https://codereview.chromium.org/16453002/diff/14002/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/16453002/diff/14002/src/ia32/code-stubs-ia32.cc#newcode7898
src/ia32/code-stubs-ia32.cc:7898: __ mov(edx, FieldOperand(ebx,
PropertyCell::kValueOffset));
nit: Better stick with Cell::kValueOffset here, it's not a property
call. Might apply to other architectures as well.
https://codereview.chromium.org/16453002/diff/14002/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/16453002/diff/14002/src/ia32/lithium-codegen-ia32.cc#newcode4173
src/ia32/lithium-codegen-ia32.cc:4173: Handle<Object>
undefined_value(isolate()->heap()->undefined_value(),
nit: Better use isolate()->factory()->undefined_value() here. Might
apply to other architectures as well.
https://codereview.chromium.org/16453002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
