Hi, all Please ignore this one. I have resubmitted to bleeding_edge. -Lijuan
-----Original Message----- From: [email protected] [mailto:[email protected]] Sent: Wednesday, June 26, 2013 2:15 PM To: [email protected] Cc: [email protected] Subject: Provide no-pic compilation option for x86 atom to improve performance (issue 17773006) Reviewers: Vyacheslav Egorov, Description: Provide no-pic compilation option for x86 atom to improve performance TEST=make android_ia32.release atom=true Please review this at https://codereview.chromium.org/17773006/ SVN Base: http://v8.googlecode.com/svn/trunk/ Affected files: M Makefile M build/android.gypi M build/standalone.gypi Index: Makefile =================================================================== --- Makefile (revision 15328) +++ Makefile (working copy) @@ -177,6 +177,9 @@ ifeq ($(armtest), on) GYPFLAGS += -Darm_test=on endif +ifeq ($(atom), true) + GYPFLAGS += -Datom=1 +endif # ----------------- available targets: -------------------- # - "dependencies": pulls in external dependencies (currently: GYP) Index: build/android.gypi =================================================================== --- build/android.gypi (revision 15328) +++ build/android.gypi (working copy) @@ -195,6 +195,12 @@ '-fno-stack-protector', ], }], + ['target_arch=="ia32" and atom==1', { + # No-pic for atom + 'cflags': [ + '-fno-pic', + ], + }], ['target_arch=="mipsel"', { # The mips toolchain currently has problems with stack-protector. 'cflags!': [ Index: build/standalone.gypi =================================================================== --- build/standalone.gypi (revision 15328) +++ build/standalone.gypi (working copy) @@ -81,6 +81,8 @@ 'arm_fpu%': 'vfpv3', 'arm_float_abi%': 'default', 'arm_thumb': 'default', + #Default IA32 variable settings. + 'atom%': 'default', }, 'target_defaults': { 'default_configuration': 'Debug', -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
