Reviewers: loislo, Sven Panne,
Description:
Extract StackFrameIteratorBase
This change introduces StackFrameIteratorBase which owns singleton frame
instances and encapsulates some basic iterator functionality. It has two
actual
implementations: StackFrameIterator and SafeStackFrameIterator.
All logic specific to frame iteration at a random point (basically checks
that
fp and sp extracted from stack frames are within current stack boundaries)
used
only by CPU profiler is now concentrated in SafeStackFrameIterator.
Generic stack iteration used in all other places is put into
StackFrameIterator.
Also this iterator unlike SafeStackFrameIterator iterates through stack
handlers.
StackAddressValidator and ExitFrameValidator classes were removed in favor
of
inline checks and simple methods.
BUG=None
Please review this at https://codereview.chromium.org/17819003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/frames-inl.h
M src/frames.h
M src/frames.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
