lgtm with comments I am not so certain about the benchmark wins. I also am
a bit
concerned about completely removing the logic that recycles segments. It
may not
show up in the core benchmarks, but keep an eye on other benchmarks to
verify
that there are really no regressions.
https://codereview.chromium.org/17827005/diff/1/src/json-parser.h
File src/json-parser.h (right):
https://codereview.chromium.org/17827005/diff/1/src/json-parser.h#newcode325
src/json-parser.h:325: ZoneList<Handle<Object> > properties(8, &zone_);
here an else where, does it make sense to wrap zone_ in a simple
accessor function zone()?
https://codereview.chromium.org/17827005/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/17827005/diff/1/src/runtime.cc#newcode6322
src/runtime.cc:6322: FindStringIndicesDispatch(isolate,
nit: Group multiple arguments per line, this burns too many lines and
doesn't improve readability.
https://codereview.chromium.org/17827005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
