LGTM with a comment.
https://codereview.chromium.org/17870002/diff/1/src/runtime.h
File src/runtime.h (right):
https://codereview.chromium.org/17870002/diff/1/src/runtime.h#newcode601
src/runtime.h:601: F(HDebugBreak, 0, 0)
As discussed offline: This only affects optimized code and not full code
on purpose and I can see the use cases for that. But I would agree with
your suggestion to make the name more expressive in that regard. How
about "DebugBreakInOptimizedCode"? The hypothetical counterpart for full
code would then be "DebugBreakInFullCode". I am also fine with
s/DebugBreak/Break/ if you prefer that.
https://codereview.chromium.org/17870002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
