Looking good, I reviewed "heap", "mark-compact" and "objects-visiting"
files.
Just a two minor comments. Let me know if I need to review the rest as well.
https://codereview.chromium.org/17895004/diff/6001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/17895004/diff/6001/src/mark-compact.cc#newcode2445
src/mark-compact.cc:2445:
ClearNonLiveDependentCode(PropertyCell::cast(cell)->dependent_code());
This iteration should only concern itself with marked property cells,
unmarked cells should be safe to ignore.
https://codereview.chromium.org/17895004/diff/6001/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://codereview.chromium.org/17895004/diff/6001/src/objects-visiting-inl.h#newcode366
src/objects-visiting-inl.h:366: //
ClearNonLivePropertyCellCodeDependencies.
nit: Comment is outdated, the function is called
ClearNonLiveReferences().
https://codereview.chromium.org/17895004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
