Thanks Yang, I updated after your comments,
--Michael
https://codereview.chromium.org/17895002/diff/1009/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/17895002/diff/1009/src/arm/code-stubs-arm.cc#newcode6270
src/arm/code-stubs-arm.cc:6270: __ cmp(tmp1, Operand(kInternalizedTag |
kStringTag));
On 2013/06/26 15:00:27, Yang wrote:
See my comment on x64.
Done.
https://codereview.chromium.org/17895002/diff/1009/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/17895002/diff/1009/src/x64/code-stubs-x64.cc#newcode5901
src/x64/code-stubs-x64.cc:5901: __ j(not_equal, &miss, Label::kNear);
On 2013/06/26 15:00:27, Yang wrote:
We could be clever here to save one instruction:
SYMBOL_TYPE is right next to the area reserved for internalized
strings.
You could check that SYMBOL_TYPE >= tmp1 >= kInternalizedTag.
Add a static assert, something like
STATIC_ASSERT((SYMBOL_TYPE - 1) & kInternalizedMask ==
kInternalizedTag);
or
STATIC_ASSERT(FIRST_NONSTRING_TYPE == SYMBOL_TYPE)
You could also put this logic into a function called
JumpIfNotUniqueName, and
reuse it later too.
Done.
https://codereview.chromium.org/17895002/diff/1009/src/x64/code-stubs-x64.cc#newcode6274
src/x64/code-stubs-x64.cc:6274: __ j(zero, &maybe_in_dictionary);
On 2013/06/26 15:00:27, Yang wrote:
JumpIfNotUniqueName that I suggested above would be nice here.
Done.
https://codereview.chromium.org/17895002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
