https://codereview.chromium.org/17432004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/17432004/diff/1/src/hydrogen.cc#newcode6416
src/hydrogen.cc:6416: if (result != value) Push(result);
On 2013/06/24 06:58:13, Sven Panne wrote:
This comparison (and similar ones elsewhere) are quite confusing, and
admittedly
I don't fully understand them. This should be refactored somehow,
perhaps using
an enum describing the intention instead of the HValue*.
We should strive to make things understandable locally, without having
to have
hydrogen.cc in one's head... :-)
+1 to sven's comment. It's really difficult to understand what the
comparison between result and value is supposed to check or verify. The
enum sounds like a good idea.
... and some comments would help, too. Why is it OK, for example, to put
the result higher up the environment stack the the value when the
simulate is made? will this really do the right thing? Don't you want to
push the result after the value, and then after the simulate pop the
result, pop the value and re-push the value?
https://codereview.chromium.org/17432004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
