https://codereview.chromium.org/17091002/diff/5001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/17091002/diff/5001/src/code-stubs-hydrogen.cc#newcode109
src/code-stubs-hydrogen.cc:109: bool ensure_context,
Turn this boolean parameter into an enum, it makes it much easier to
understand at the caller site what's going on.
https://codereview.chromium.org/17091002/diff/5001/src/code-stubs-hydrogen.cc#newcode110
src/code-stubs-hydrogen.cc:110: bool disable_allocation_sites,
Turn this boolean parameter into an enum, it makes it much easier to
understand
at the caller site what's going on. In this case, you may want to make
it part of AllocationSite, e.g. AllocationSite::MementoState with values
AllocationSite::MEMENTOS_ENABLED and AllocationSite::MEMENTOS_DISABLED
https://codereview.chromium.org/17091002/diff/5001/src/code-stubs-hydrogen.cc#newcode114
src/code-stubs-hydrogen.cc:114: bool disable_allocation_sites,
Same as above
https://codereview.chromium.org/17091002/diff/5001/src/code-stubs-hydrogen.cc#newcode550
src/code-stubs-hydrogen.cc:550: return BuildArrayConstructorImpl(kind,
constructor,
the return clause is common code, how about factoring it out and putting
it after the if
https://codereview.chromium.org/17091002/diff/5001/src/code-stubs-hydrogen.cc#newcode579
src/code-stubs-hydrogen.cc:579:
Not sure this additional line makes a big difference :-)
https://codereview.chromium.org/17091002/diff/5001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/17091002/diff/5001/src/hydrogen.cc#newcode1784
src/hydrogen.cc:1784: // No need for a context lookup in this case.
Why not? What is special about smi elements?
https://codereview.chromium.org/17091002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
