Thanks - addressed your nits and restored 644 file mode for the files I've touched. Seems my editor is somehow messing this up.On a tangent, the file mode for *.h and *.cc files is inconsistent in the github
clone of V8 at least.
https://codereview.chromium.org/16578008/diff/50001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/16578008/diff/50001/src/bootstrapper.cc#newcode2579 src/bootstrapper.cc:2579: if (isolate->initialized_from_snapshot()) On 2013/06/25 18:40:35, danno wrote:
V8 style nit: then/else blocks wrapped in {}
Done. https://codereview.chromium.org/16578008/diff/50001/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/16578008/diff/50001/src/ic.cc#newcode42 src/ic.cc:42: On 2013/06/25 18:40:35, danno wrote:
Stray whitespace change?
Oops, had some code there earlier, fixed. https://codereview.chromium.org/16578008/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
