LGTM if you merge the 'conditions' sections.
Also, please verify that with this change V8 still compiles when embedded
into
Chrome (where standalone.gypi isn't used).
https://codereview.chromium.org/18181006/diff/1/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/18181006/diff/1/build/standalone.gypi#newcode33
build/standalone.gypi:33: 'clang%': 0,
What's this needed for?
https://codereview.chromium.org/18181006/diff/1/build/standalone.gypi#newcode94
build/standalone.gypi:94: ['OS == "win"', {
Please merge this into the existing 'conditions' section in line 76.
https://codereview.chromium.org/18181006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
